[2.2.9] Improve build time - #3022
Conversation
c60d7e8 to
742e072
Compare
bfaa7b3 to
c621fcf
Compare
ba25ccb to
2e2feda
Compare
damianoc90
left a comment
There was a problem hiding this comment.
Reviewed the whole diff. The build work is well argued — the retry ladder wipes the workspace between attempts, every step is bounded and the jobs now have their own timeouts, and the tj-actions/changed-files pin is honest: I checked that 9426d409… really is the commit behind v47.0.6.
Three things I would fix before merge (first two inline below, plus the cache-save guard), and a few worth a look.
Not worth their own threads:
npm install->npm ci. For a lockfile-driven deployciis the right verb and is usually faster with a warm npm cache;installcan rewrite the lockfile in CI.- Action majors. They all exist, but several are one or two behind: checkout v5 (latest v7), setup-node v5 (v7), cache v5 (v6).
upload-artifact@v7/download-artifact@v8are current. If the lag is deliberate, fine — but this is the PR that touches all of them. xargs … || echo "continuing"swallows a systemic failure too, not just the handful of .png files that are really JPEGs. Ifoptipngfails to install, the build proceeds with uncompressed images and says so only in a log line.- The third checkout attempt has no
timeout-minutes. Fine as it stands, since the new job timeout bounds it — worth a word in the comment so it reads as a choice.
|
Thanks — the four items outside the threads, in order.
Action majors one or two behind. Deliberate for this PR. We learned the cost the hard way: bumping Node 18 -> 22 added
Third checkout attempt without |
Speed up deploy builds and stop stalled checkouts from hanging